Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change language of the site #138

Merged
merged 13 commits into from
Jun 6, 2017
Merged

Add option to change language of the site #138

merged 13 commits into from
Jun 6, 2017

Conversation

m4v15
Copy link
Member

@m4v15 m4v15 commented Jun 5, 2017

relates to issue #134 #100 #20

app.js Outdated
@@ -2,23 +2,32 @@ const path = require('path')
const express = require('express')
const hbs = require('express-handlebars')
const router = require('./routes/index.js')
const text = require('./text.js').english
var bodyParser = require('body-parser')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using var instead of const

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!


const pubPath = path.join(__dirname, './', 'public')

app.use(bodyParser.urlencoded({extended: false}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this line do ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means post requests are parsed automatically or something

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbesraa jbesraa merged commit bffb6ca into master Jun 6, 2017
@jbesraa jbesraa deleted the languageChange branch June 6, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants